roslyn
roslyn copied to clipboard
[API Proposal]: Breaking change - Make some types static
Background and Motivation
See discussion in #65830
Proposed API
Namespace Microsoft.CodeAnalysis.VisualBasic
- Partial Public Class SyntaxFacts
+ Partial Public NotInheritable Class SyntaxFacts
+ Private Sub New()
+ End Sub
End Class
End Namespace
Namespace Microsoft.CodeAnalysis.VisualBasic.Syntax
- Public Class SyntaxNodeRemover
+ Public NotInheritable Class SyntaxNodeRemover
+ Private Sub New()
+ End Sub
End Class
End Namespace
namespace Microsoft.CodeAnalysis.CodeStyle
{
- public class CodeStyleOptions
+ public static class CodeStyleOptions
{
}
}
Note, our next API review session isn't until Jan 5th (much of the office is out for US holidays), so it'll be a bit before we get to this.
API Review
- First two are already static on the C# side, seems ok
- Third has similar examples on other option holder types.
Conclusion: Approved.