Fred Silberberg
Fred Silberberg
Alright, looks like there's a conflict @Youssef1313.
## API Review * API is approved. ```cs public class CompilationWithAnalyzers { public CompilationWithAnalyzers( Compilation compilation, ImmutableArray analyzers, CompilationWithAnalyzersOptions analysisOptions, CancellationToken cancellationToken); } ```
I don't think I have time to walk through these changes before I'm out for the rest of the week. @jjonescz, when I get back I could use a walkthrough...
Oh, and just above it, `T` should be `T`
Finally, the section is header is not particularly clearly worded. ``A type `T` is variance-convertible to a type `T` if `T` is either an interface or a delegate type...`` defines...
I have pulled this into a separate extension on the vscode marketplace, https://marketplace.visualstudio.com/items?itemName=333fred.net-compiler-developer-sdk, which supports the new roslyn-based LSP host as well as devkit.
Closing this out as stale and not going to be implemented.
I'm interested enough in this to see what the rest of the LDM thinks. There are certainly times that this could be useful in Roslyn.
Unless and until a member of the LDM decides to bring it for retriage, we won't accept pull requests for this feature. To speak to how much work this feature...
> how do we get somebody of the LDM to retriage this By giving us persuasive examples of how this would improve code enough to be worth the effort. Remember,...