Elias Rohrer

Post-https://github.com/lightningdevkit/rust-lightning/pull/4160 we should def. also create a separate error variant for 'HTLC intercepted failed due to unknown SCID'.

> Hi [@tnull](https://github.com/tnull) [@martinsaposnic](https://github.com/martinsaposnic) could I give it a try at this issue? Thanks for showing interest here! While the actual code changes should be trivial, this would be a...

> Basically LGTM! > > Could you confirm one thing for me: if we fail to receive an HTLC that's destined for us, it will then be put into the...

Since the other Lightning implementations seem to just map `Testnet4` to `Testnet`, I now updated this PR to follow suit and *not* introduce a new `Currency` variant. Note this could...

> Hmm, yea, this is fine. Annoying, but fine. Maybe the docs for `Currency::Testnet` should be updated to reference that its both? Amended with some more docs: ```diff > git...

> `blockchain.transaction.broadcast_package` support has been merged. Awesome, I'll see to get the ball rolling on `rust-electrum-client` soon then.

> Tracing dependencies: > > ``` > ├── tracing v0.1.41 > │ ├── pin-project-lite v0.2.16 > │ ├── tracing-attributes v0.1.30 (proc-macro) > │ │ ├── proc-macro2 v1.0.103 (*) > │...

> Okay, but "they were intentionally done this way" isn't really a strong argument for keeping them that way. My point here is that, in writing some persistence logic, I...

> The biggest difference here is that its incredibly easy to swap `CHANNEL_MONITOR_PERSISTENCE_PRIMARY_NAMESPACE` and `CHANNEL_MONITOR_UPDATE_PERSISTENCE_PRIMARY_NAMESPACE`. Because both are so long, and the relevant bit is in the middle of the...

> but we're supposed to allow back-to-back connections of the same block with more txn. Not sure I follow what this means. Aren't we supposed to always give the full...