Elias Rohrer

Results 301 comments of Elias Rohrer

> It does, though it should usually be fine - writes shouldn't immediately fail unless we're like out of disk space, at which point we should really panic and crash...

> I can see how the large size can be a constraint for environments with smaller stack sizes/limited memory. Sure, not denying it can become an issue in certain circumstances....

> I'm not super familiar with the bench setup in LDK, but I tried running `channelmanager::bench_sends` before and after this PR on an M1 mac: Did you adjust the sample...

@jirijakes Are you already working on this or did you intend to soon? Otherwise I'm happy to pick this up next week.

> I have not started yet and I don't think I would get to it before second half of June. So, please feel free to start. Alright, then I'll see...

> There's a lot going on in this crate right now for the bech32 upgrade, sadly, so I'm afraid this might want to wait :/ Yeah, I agree. Happy to...

Rebased to resolve conflicts with `main`

Rebased after #3270 landed.

Rebased once more to address minor conflicts.

Rebased and addressed comments.