lightningdevkit
`lightning-liquidity`: Introduce better error types
In lightning-liqudity we historically at some point went with reusing LDK's APIError type, which was a weird choice even back then.
However, we since added a bunch of additional error cases, and at the very least since #4008 (where we had to use APIError for inline persistence errors), APIError makes no sense anymore.
We should introduce a dedicated error type with clearly documented variants for lightning-liquidity and use it throughout the LSPS1/2/5 APIs.
Post-https://github.com/lightningdevkit/rust-lightning/pull/4160 we should def. also create a separate error variant for 'HTLC intercepted failed due to unknown SCID'.
Hi @tnull @martinsaposnic could I give it a try at this issue?
Thanks for showing interest here! While the actual code changes should be trivial, this would be a rather substantial refactor in terms of API design. As it will require a bunch of context (esp about the shortcomings we found in our current design), it's probably no 'good first issue'.
Oh ok @tnull, thanks for the advice. I am going to look for a 'good first issue'