Elias Rohrer

Results 302 comments of Elias Rohrer

For LSPS1 the steps are roughly: 1. Configure `LiquidityManager` by setting the `LSPS1ClientConfig` and set it as your `CustomMessageHandler` in `MessagHandler` that you give to `PeerManager` 2. Start handling `LiquidityManager`...

> Hi [@TheBlueMatt](https://github.com/TheBlueMatt), I would like to pick this up. Is anyone currently working on it? Sure, go for it!

> I mean this is generally true of Rust? If you have non-dynamic dispatch you have to specify the types of the things you're calling. Right, but it makes these...

> Can you provide a reproducer? That shouldn't be the case, AFAIU (though you may have to do an explicit cast when building the Arc). Sure. I did multiple attempts...

@TheBlueMatt Did you get a chance to look at the reproducer? Somewhat independently from that, would you be fine with going ahead with the approach outlined above? @vincenzopalazzo had previously...

> With this diff upstream: > .. > this diff on top of your branch works: > .. Nice, thanks for looking into it, that's a great first step! However...

> Honestly maybe we should just bite the bullet and move the outbound message queue into NetworkGraph from P2PGossipSync and we can remove all the passing around of a reference...

> I'm not quite sure why that would be confusing? It wouldn't change the public API at all (aside from removing the need for the reference back to the P2PGossip...

> With this diff upstream: Now opened #3432 with this diff to make sure we ship *a* solution with the next release.

> I think it's okay to break things completely since it's just a client library. Aiming for "minimal changes" shouldn't be one of our requirements imo. In this regard, I...