Elias Rohrer

@johncantrell97 Any interest in finishing this PR?

> What is the current purpose of insert_tx and how does it compare to apply_unconfirmed_txs? I don't see insert_tx used anywhere internally. Also brought this up on Discord, but I'm...

Rebased on `main` to resolve conflicts.

Force-pushed the following changes: ```diff > git diff-tree -U2 7883f502f 35710958f diff --git a/ci/ci-tests.sh b/ci/ci-tests.sh index 1a912016e..a0dc27d5a 100755 --- a/ci/ci-tests.sh +++ b/ci/ci-tests.sh @@ -45,20 +45,21 @@ popd if [[ "$HOST_PLATFORM"...

Force-pushed once more: ```diff > git diff-tree -U2 35710958f 43bc78ce3 diff --git a/ci/ci-tests.sh b/ci/ci-tests.sh index a0dc27d5a..43d6aeaa4 100755 --- a/ci/ci-tests.sh +++ b/ci/ci-tests.sh @@ -54,4 +54,5 @@ if [[ "$HOST_PLATFORM" != *windows*...

Thinking about it, I also wonder why the default isn't `Unbounded`? Why do we default to this "quantity-is-unset-implictly-meaning-its-one" variant?

> I believe we are compliant with the spec: Hmm, that might be the case, but it's a very confusing (and error-prone) API if `Quantity::Bounded(1)` and `Quantity::One` are two completely...

> Currently, they need to call `Offer::supported_quantity` though as suppose we could do that for them in `pay_for_offer`. But they would pass a `u64` not `Quantity` if we remove the...

> Instead, if the user doesn't specify a quantity when calling `pay_for_offer`, we could possibly translate it to `Some(1)` if `Offer::supported_quantity` is `Quantity::Bounded(1)`. Hmm, then I also wonder if we...

> Hmm, maybe? Its still a failed payment and we still need to "punish" the node, however. For RGS users this can get hit sometimes, but best to punish that...