Elias Rohrer

Results 301 comments of Elias Rohrer

> Does that sound good you @tnull and @matthiasdebernardini? > > I am thinking on something similar to the esplora implementation above, that you pass a `target` as a parameter....

> Ugh, can we split this? 42 commits in one PR is just a lot... Alright, happy to if you prefer (although at least half of these commits are one-line...

Rebased after https://github.com/lightningdevkit/rust-lightning/pull/3327 landed.

Rebased after #3324 landed.

Rebased to resolve minor conflicts.

Rebased once more to resolve minor conflicts. Any additional comments here after we landed the split-out commits in #3324, @TheBlueMatt ?

Rebased once more to resolve minor conflicts.

Addressed all but one comment.

Rebased once more to resolve minor conflict. @TheBlueMatt any further comments here?

Fixed the missing `unwrap` and rebased on main as this PR is ancient and I wanted to ensure there were no silent conflicts in the meantime: ``` > git range-diff...