Elias Rohrer

Results 301 comments of Elias Rohrer

I don't think you can currently deprecate a re-export? https://github.com/rust-lang/rust/issues/30827 But still, switching to `lightning::types` and possibly refactoring a good chunk of modules now would be a good idea?

> IMO we already have a good bit of API breakage in this release, it'd be kinda nice to put off yet more until the next one. Right, I meant...

> I'm not sure which "data model" we are referring to here. The one we support is sqlite where this is backwards compatible and transparent change. Are we talking about...

> We are making breaking changes to `bdk_wallet`'s `ChangeSet` type in the next major version release. This is going to be part of that release. Even across major versions the...

> @tnull Changeset serialization format is definitely going to be backwards compatible. In terms of [Cargo semver](https://doc.rust-lang.org/cargo/reference/semver.html), these are breaking changes. Hmm, okay, still confused what you mean by 'ChangeSet...

> @tnull are you able to be specific with what you want? Well, what I stated multiple times previously: clear, **documented** guidance on what guarantees implementors can lean on. So...

Might want to hold off until they fixed https://github.com/bitcoindevkit/rust-esplora-client/issues/102

Should be good for review, now that they shipped `esplora-client` 0.11 which replaces the `async-std` dependency with a trait implementation defaulting to `tokio` at least, which users of this very...

> I'm not sure I quite understand the desire to serialize this. We use it to keep track of things as we fetch them, but generally shouldn't ever need the...

> Alternatively (or in addition), we could manually update the cache at each iteration during initialization from the `ChainDifference`, which would mean we'd want some `AppendOnlyCache` instead of a `ReadOnlyCache`...