Elias Rohrer
Elias Rohrer
> I was just emulating what we already do in [`rust-esplora-client`](https://github.com/bitcoindevkit/rust-esplora-client/blob/6002aeaeea220ab3aa80f88b7d8a1f9306a292f6/src/lib.rs#L89-L102): > > ```rust > /// Get a fee value in sats/vbytes from the estimates > /// that matches the...
> I think the math is right, but the existing test might need to be updated. What you think? As discussed offline, I think the tests need fixing.
> The tests are CRAZY! They are even not reproducible. They pretty much ping a live server `electrum.blockstream.info:50001`. So I added the tests for the fees to make sure that...
@oleonardolima Are you interested in picking this up? Otherwise I might, although it may be while until I get to it.
It might be a bit late to mention this, but given that we'll need to introduce similar variants for `LiquidiityManager` in/post #3509, I wonder if we should use a builder...
Sure, go for it!
Is this sufficiently covered by https://github.com/lightningdevkit/rust-lightning/pull/1359, or do we want even more randomization?
Seems this unfortunately needs a rebase by now.
> Potentially fixes #91. > > I wanted to take a stab at this but I'm not sure I really understood why `proxy` was a feature in the first place....
I think prior to BDK 1.0 the crate depended on `log`, which was however dropped. There were also prior discussion at https://github.com/bitcoindevkit/bdk/issues/1222 that concluded logging wasn't needed. Personally I think...