lightningdevkit
Add `BackgroundProcessor::start_without_om`
BackgroundProcessor::start takes an Option for the OnionMessenger which is quite annoying as it requires a concrete type for the OnionMessenger even when passing None. We should add a new constructor to make this easier for users.
Hi @TheBlueMatt, I'll like to work on this issue. Can it be assigned to me please?
It might be a bit late to mention this, but given that we'll need to introduce similar variants for LiquidiityManager in/post #3509, I wonder if we should use a builder pattern or have the BP take a BackgroundProcessorConfig or similar?
Otherwise the API might get a bit messy if we add constructors for all combinations of parameters?
It might be a bit late to mention this, but given that we'll need to introduce similar variants for
LiquidiityManagerin/post #3509, I wonder if we should use a builder pattern or have the BP take aBackgroundProcessorConfigor similar?Otherwise the API might get a bit messy if we add constructors for all combinations of parameters?
Good call @tnull. IMO I believe the builder pattern is the most flexible solution that can easily accommodate future additions. I'll open a PR for this mid next week.