Elias Rohrer

Squashed fixups without further changes.

> I'm pretty sure the first commit should be squashed-into, its entirely changed by the second commit. Ah, true, squashed it in and rebased to make CI happy. However now...

Squashed without further changes.

Force-pushed the following fixups: ```diff > git diff-tree -U2 9ee73dfb3 44cf6928d diff --git a/lightning/src/ln/features.rs b/lightning/src/ln/features.rs index 9a0c2b30e..8de57c2b9 100644 --- a/lightning/src/ln/features.rs +++ b/lightning/src/ln/features.rs @@ -788,5 +788,5 @@ impl Features { if...

> first question is what file handles the channel close event @TheBlueMatt You can find this event type in the documentation: https://docs.rs/lightning/latest/lightning/util/events/enum.Event.html#variant.ChannelClosed

After some offline discussion with @TheBlueMatt we arrived at the conclusion that we should limit *both* the `htlc_maximum_msat` and `max_htlc_value_in_flight_msat` and switch them based on the announcement status. That is,...

> Hii, In the issue [comment](https://github.com/lightningdevkit/rust-lightning/issues/2851#issuecomment-1972996034) you said we have to limit actual `htlc_maximum_msat` we set Yes, but as mentioned above, after some offline discussion we concluded that we want...

> Ok , > > > That is, the changes likely need to happen in `ChannelContext::get_holder_max_htlc_value_in_flight_msat` _and_ `ChannelContext::get_announced_htlc_max_msat`. However, the latter is a slightly orthogonal issue that probably needs to...

> yes i got that, My question was `fn get_holder_max_htlc_value_in_flight_msat` is not in the scope of `ChannelContext`, so for solving this particular issue should i update the `fn get_holder_max_htlc_value_in_flight_msat` so...

> Hii, I am working on #2851 can i also try this? Sure, although it would probably make sense to work sequentially on this, i.e., first finish the previous task...