stuartmorgan-g

Results 1177 comments of stuartmorgan-g
trafficstars

This seems easier than fixing up all of the dependabot PRs for annotation.

Hm, looks like this is hitting a resolver conflict with something that requires 1.2.0. I'll have to investigate more.

As a high-level note: as discussed in your previous PR, we require test coverage. There's currently no testing of the native part of this change, which is the most important...

> @stuartmorgan indeed I get that, in the meantime is there somebody at Flutter that can help me with that? If you have specific questions, please ask them and someone...

Also, you need to follow https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins so that the PR can actually run tests.

If you removed all of the code from `setPictureInPicture:`, and hard-coded `isPictureInPictureSupported:` to return `YES`, would any of your tests fail? I haven't tried running them, but it looks like...

> This is the automated test. I understand what actions the test is taking; that wasn't my question. Tests aren't just actions, they are also assertions about the outcomes of...

> And that the `Start Pip` changes to `Stop Pip` after pressing `Start Pip` That's pretty much only testing: - that some Dart example code logic works as expected (which...

> But for UI testing that would be the only tests I could do right? That they would should be done in Unit tests, I think. I don't think that's...

> @stuartmorgan Just tested this and Yes, If I remove the code from `setPictureInPicture` and hard-code `isPictureInPictureSupported` to `YES` my UI tests fail. I missed that the enabled state was...