stuartmorgan-g

Results 1177 comments of stuartmorgan-g
trafficstars

Reviewers can provide feedback on whether there are additional elements that should be tested.

Sounds like it should be.

@GaryQian Ping on this one; it needs some intervention to fix failing tests.

@darshankawar Why do you believe that this is a `file_selector` issue rather than an include path misconfiguration in `firebase_auth`? The build error is in `firebase_auth`.

This is definitely a `firebase_auth` bug; see https://github.com/flutter/flutter/issues/111728 for details.

@bparrishMines Looks like the implementations are approved, and this needs an app-facing-package API review.

This seems *really* fragile. > To follow this spirit, we should probably rely on platform views with `AVPlayerLayer` attached. This would be a huge change from the current implementation though...

Thanks for the submission! In the future, please do not delete the checklist that is in the PR template; it is there for a reason. This PR is missing required...

Thanks for the submission! We’re currently working through a large backlog of PRs, and this will require non-trivial review, so it will take some time before we’re able to review...