stuartmorgan-g
stuartmorgan-g
I tried to resolve the (trivial) conflicts created by the other Pigeon PR I just landed, but for some reason the GitHub UI resolver UI keeps failing to commit the...
Thanks! I should have landed the two PRs in the other order, I just wasn't thinking about the fact that there were two when I was going through email.
@bparrishMines @dnfield This is a WIP since I still need to add tests, but I wanted to post it to get initial feedback on the approach.
The new golden tests I added have somewhat odd visual output where the top of the platform view square is white and the bottom is pale grey, instead of the...
I haven't had a chance to look yet (I'm OOO today) but I'm pretty sure anyone trying to do what the PR describes enabling will hit https://github.com/flutter/flutter/issues/74735 So we should...
Landing manually; `publishabel` failure is incorrect due to https://github.com/cirruslabs/cirrus-ci-docs/issues/1054
Assuming we actually want to expose this functionally (which hasn't actually been decided): why is this so complex? If this isn't going to be a fully-fledged runner with things like...
> When is it going to be decided if this should be exposed? @cbracken should review and decide. > My primary use case is having the possibility of using `EventChannel`s...
> for consistency with the mobile embedders How so? We don't have an API for this on mobile (since the OS provides one).
Right, the reason I think we shouldn't do what this PR does, and instead make calling back safe from other threads, is that doing *that* is consistent with mobile. Prior...