stuartmorgan-g

Results 1177 comments of stuartmorgan-g
trafficstars

I don't quite follow the explanation (perhaps because I don't have a lot of experience with Robolectric). @utzcoz Can you elaborate on what the problem in the test is exactly?

What's the status of this PR? Is it waiting for updates, or for another round of reviews?

There's no auto-assignment set up for this repository. We do a weekly triage and route to reviewers that way.

> @stuartmorgan should I also update dependencies in pubspec.yaml? Since the versions used were to support non-null safe code with +2 to allow null safe. Yes, a null-safe package should...

@yjbanov should do the primary review on this.

@yjbanov Ping on this review?

Thanks for the submission! This will need a test per the comment above before we can move forward with it.

Presumably you are adding this for a reason; what were you trying to do that didn't work without that PR? That's what you should test.

@Lyokone Are you planning on adding a test per the discussion above?

The formatting of the example code in this project appears to have been mangled; see [the original instructions from flutter-desktop-embedding](https://github.com/google/flutter-desktop-embedding/blob/master/Flutter-Requirements.md#target-platform-override) for the correct version.