stuartmorgan-g
stuartmorgan-g
> * `initExpensiveAndroidView` -> always TLHC (?) This PR doesn't change the behavior of `initExpensiveAndroidView`. It continues to always use HC. > What would be used by default by `AndroidView`?...
I'm not familiar with the internal build setup of Android plugins; @blasten would be a better reviewer.
> > My question about tests hasn't been resolved; this is still missing tests. > > @stuartmorgan Is that mean that I should wrote a *_test.dart file to test this...
> [The issue](https://github.com/flutter/flutter/issues/92252) methioned by this pr only can be reproduced by running multiple build task simultaneously. And [the issue](https://github.com/flutter/flutter/issues/92252) was appeared Occasionally. A test does not necessarily need to...
> Now , the test [android_plugin_multiple_build_tasks_test.dart](https://github.com/chunfengyao/flutter/blob/chunfengyao-patch-for-issue-92252/packages/flutter_tools/test/integration.shard/android_plugin_multiple_build_tasks_test.dart) will failed when the issue regressed. As far as I can tell you are just trying to recreate the race condition in the test,...
> If the pipline ran and passed this test , It can make sure the issue was not regressed. What line in the test will deterministically fail without the other...
> > What line in the test will deterministically fail without the other changes in the PR? > > @stuartmorgan [Line 132](https://github.com/chunfengyao/flutter/blob/chunfengyao-patch-for-issue-92252/packages/flutter_tools/test/integration.shard/android_plugin_multiple_build_tasks_test.dart#L132) may failed if `plugin_test` and `plugin_bg_test` runned simultaneously...
Can you elaborate on why it's difficult to write a test that verifies that build output was created in an expected location? I'm not clear on where the issue is....
> > Can you elaborate on why it's difficult to write a test that verifies that build output was created in an expected location? I'm not clear on where the...
It's in the `stdout` link for the failing step. That was an out-of-band failure unrelated to your PR though; you just need to merge in the latest `master`.