stuartmorgan-g

Results 1165 comments of stuartmorgan-g
trafficstars

https://github.com/flutter/flutter/issues/93732 is complete, so this is unblocked; you'll just need to update the implementation for the new Dart-based implementation (and make it a configuration option at creation time, per the...

@EArminjon2 Are you still planning on updating this per the discussion above?

Okay, I'm going to go ahead and close this then, since it's not something we can proceed with without those changes. Please feel free to open a new PR if...

I'm not sure we actually need a breaking change. It seems like we could: 1. Separate that call out of `initialize` on the native side (which needs to be done...

> I'm suggesting we make it a breaking change because the current default behavior is wrong (ie the plugin is implicitly mutating global state) and we should change that. At...

> How about the options specific to iOS ( like category, session mode and etc )? When it get added to VideoPlayerOptions, should it get discarded by Android implementation? Or...

@mitghi What questions are you referring to? I don't see anything since my last round of feedback.

> @stuartmorgan I left a comment in the review section under your message about breaking change I can't see that anywhere; perhaps you forgot to publish it and it's still...

@mitghi Are you still planning on updating this per the last comments about changing the init flow?

Closing since I haven't had time to get back to this. It's still something we need to resolve though, as this has quite a few outdated dependencies.