stuartmorgan-g

Thanks, sounds like we'll need to look into setting up a platform subclass system for `MediaSettings` the way we've done for settings objects in some other plugins then.

> That meant the package didn't have a package config, so the formatter defaulted to the latest language version (and thus the new style) even though the code was actually...

> 4\. Do nothing. If we don't want a complex solution, 2 would be dramatically better than 4 IMO. It is hard to overstate how much worse mysterious failures are...

> @stuartmorgan does this change need a test? It shouldn't be changing any behaviors, I'm not sure how a test would work honestly. The fact that it's a more efficient...

From triage: what's the status of this PR? Is it ready for re-review?

> Now I don't know why that test is failing. @stuartmorgan have you seen this type of failure with the analyze legacy tests before? Yes. The output explains the problem...

From triage: @abdelaziz-mahdy Are you still planning to update this PR based on the review comments?

> if we need to eliminate the not sorted to avoid the duplicate, i think we can do that, what do you think? Unfortunately: - the API of the caption...

@abdelaziz-mahdy Are you still planning on updating this PR to address the review comments above?

Marking as a draft pending updates.