stuartmorgan-g

Results 1356 comments of stuartmorgan-g

> This change avoids enabling hot reload in the flutter drive tests since they rely on > `-d web-server` which has known startup issues. When [dart-lang/sdk#60289](https://github.com/dart-lang/sdk/issues/60289) is > resolved it...

> Our aim is to fix the `-d web-server` issue or revert this change by the beta 3 release. To clarify, flutter/packages runs against Flutter `master`, using a pinned, auto-rolled...

Adding a minute or two to the publish step is fine. We'll need to add repo tooling for packages to be able to specify a pre-publish hook, probably via a...

> @stuartmorgan WRT to testing, is there a way to add an integration test hook to the CI? For example, the flutter/devtools CI has this code to run the flutter...

https://github.com/flutter/packages/blob/main/script/tool/lib/src/drive_examples_command.dart is this repo's CI driver for integration tests. I just realized this package isn't a library with an `example/` though, so we'd need to make it understand top-level app...

> The last thing I think we need to do before landing this Before the PR lands, either the `shared_preferences` changes need to be reverted, or the repo tooling to...

> But for `devtools_app_shared` and `devtools_extensions` I'd need to add them to the config. Should I add them to [allowed_unpinned_deps](https://github.com/flutter/packages/blob/b7bcb4bd126705c4f5f85e9470f50d4cfbc32011/script/configs/allowed_unpinned_deps.yaml#L18) or to [allowed_pinned_deps](https://github.com/flutter/packages/blob/b7bcb4bd126705c4f5f85e9470f50d4cfbc32011/script/configs/allowed_pinned_deps.yaml#L23)? Unpinned is fine. (We may actually remove...

From triage: I'm currently looking at the blocking issue.

https://github.com/flutter/packages/pull/7156 should unblock this when it lands, since at that point a script can be added here that will do the sub-build-and-copy.

I think you're missing a `shared_preferences` in the `dest` path, but otherwise that sounds about right to me.