stuartmorgan-g

Results 1342 comments of stuartmorgan-g

@Ortes Is this updated to match the current state of https://github.com/flutter/packages/pull/8979 ?

@misos1 Are you still planning on addressing the remaining comments?

Sorry, I didn't realize that was waiting for my input. I'll respond there.

> Seems this is caused by a bug in the flutter engine. Please definitely file an issue with details if you haven't already! Edited to add: You can cross-reference the...

> There is also this "Note that Core Video doesn’t explicitly declare any pixel format types as Metal compatible. Specify true for the kCVPixelBufferMetalCompatibilityKey option to create Metal-compatible buffers when...

In terms of moving this forward, from my perspective: - Structurally everything here makes sense to me at this point; thanks again for the clear explanations! - I don't consider...

> I wonder why no one reported this. I think they have, per my edit to [this comment above](https://github.com/flutter/packages/pull/7466#issuecomment-2377660399). Unless that's not the same behavior you're describing? > And there...

Whether we try to work around engine bugs at the plugin level is something we decide on a case-by-cases basis. If the macOS engine texture pipeline is buggy, I would...

I'm not really sure what you mean by "for every frame", but if you want to propose a new engine API the place to start would be a [design document](https://github.com/flutter/flutter/blob/master/docs/contributing/Design-Documents.md)....

In case this was waiting on me, the changes here LGTM. I was just waiting until the merge to pass CI has happened for final review+approval, since that merge will...