stuartmorgan-g

Results 1317 comments of stuartmorgan-g

Since this is marked as a draft and hasn't been updated in several months, I’m going to close it so that our PR queue reflects active PRs. Please don't hesitate...

Sorry, this fell off my review queue. @hellohuanlin can you take a look as well?

This will just need conflicts resolved against the code location refactoring, and then it can be landed!

This happened once before with another PR; I was never able to figure out what caused GitHub to put it into this state, or why :(

> Now I am planning to check that problem with `defaultRate` on ios 16 (as I now have more info about it), so please wait. Since this PR improves over...

That failure was flake that I've seen outside of this PR, so I believe to be unrelated.

> I (fortunately) don't think that any cases are broken. > > There would only be a problem if either the `forceWebView` or `forceSafariVC` default was `true`. Why would a...

> Since it would only affect the last two cases, it would make them the middle cases and the outputs are exactly the same. That is not correct. Have you...

> Am I missing anything still? Yes; all of [the failures flagged by CI](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8712342398102760305/+/u/Run_package_tests/CHANGELOG_and_version_validation/stdout) need to be resolved.

Version/CHANGELOG override: Although the change is to example/lib/main.dart, and thus usually requires a version change since it's published on pub.dev, the `// ignore` isn't important for the use case of...