stuartmorgan-g

Results 1319 comments of stuartmorgan-g

@misos1 Could you split this into two different PRs? Having non-trivial changes to two unrelated plugins in the same PR makes review much more difficult.

Sorry, this slipped through the cracks on getting landed. (@hellohuanlin Please make sure to add the `autosubmit` label when doing the last review on a non-member PR.)

Wouldn't this also allow warnings that are podspec-level warnings rather than code-level warnings? In pratice, if things don't fail CI, people almost never look at the output, so "allow warnings"...

> * [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. `[shared_preferences]` This was not done; please don't check boxes without...

Tiny changes in golden files are normal if you are on a different host OS than the baseline (which is usually Linux). The issue on CI though is that you've...

From triage: @M97Chahboun Are you planning on updating the tests per the comments above?

Marking as a draft pending new, passing tests that can be reviewed.

Since this is marked as a draft and hasn't been updated in several months, I’m going to close it so that our PR queue reflects active PRs. Please don't hesitate...

From triage: @domesticmouse it looks like this is ready for re-review.

@M97Chahboun The test failures are in your new test; merging in main isn't going to resolve them, it's just unnecessarily triggering all of the CI again each time.