packages
packages copied to clipboard
[video_player] Add poster attribute for html video tag in video_player_platform_interface
This PR adds support for the poster attribute on web by introducing a poster field in VideoPlayerWebOptions. It allows setting a thumbnail image for videos using the native HTML5 poster property, improving the out-of-the-box web experience.
This PR is is the changes to platform_interface for this one
Solve this issue: https://github.com/flutter/flutter/issues/166232
Pre-Review Checklist
- [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [x] I read the Tree Hygiene page, which explains my responsibilities.
- [x] I read and followed the relevant style guides and ran the auto-formatter.
- [x] I signed the CLA.
- [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g.
[shared_preferences] - [x] I linked to at least one issue that this PR fixes in the description above.
- [x] I updated
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under[^1]. - [x] I updated
CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under[^1]. - [x] I updated/added any relevant documentation (doc comments with
///). - [x] I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under[^1].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Marking as a draft since, per the documented process, the creation of this PR should happen only after the combined PR has been approved.
Greetings from stale PR triage 👋, what is the status of this PR? Looking through it and the linked PRs we weren't sure.
@Ortes Is this updated to match the current state of https://github.com/flutter/packages/pull/8979 ?
@Ortes Is this updated to match the current state of #8979 ?
Yes all fine,
Sorry for the mess I made while trying to rebase
Thanks for the review @stuartmorgan-g hopefully it is all fixed