Steven Weerdenburg comments

Results 453 comments of


                                            Steven Weerdenburg

CancelAfter & TestCaseSource with CancellationToken method parameter cause test failures

This should get fixed as part of #1883 . The resultant PR will add handling for both

When I run NUnit tests in VSTest in the pipeline it goes ok, but when I want to rerun failed once there is a filter from MSTest "ClassName"

Thanks for raising this @Misieqj I'm not 100% certain, but this could also be related to a framework filtering issue we've fixed for the upcoming NUnit 4.2 release. There is...

When I run NUnit tests in VSTest in the pipeline it goes ok, but when I want to rerun failed once there is a filter from MSTest "ClassName"

The issue I suspect you could be hitting is https://github.com/nunit/nunit/issues/4651

Generic Test Fixtures not run from VS Test Explorer

I recall there may be prefilter logic in the framework itself too. We should consider looking there as well as part of any investigation

Modular Structure of the Engine

Thanks for the extensive write up and organization of issues here @CharliePoole . Lots to read and catch up on past discussions

Allow specifying max test duration as a string-formatted TimeSpan

Hi @EdLichtman Thanks for your proposal, and sorry it's taken us a bit to get back to you. I'm hoping we can take a step back to confirm the desired...

Allow specifying max test duration as a string-formatted TimeSpan

`CancelAfter` should also likely be an option here if you were to register a callback on the context's cancellation token from which you could do things like abort the transaction....

Allow specifying max test duration as a string-formatted TimeSpan

I suppose a bit of an assumption was baked into my suggesting of `MaxTime`. You're quite right that it would only mark the test as failed; the test itself would...

Allow specifying max test duration as a string-formatted TimeSpan

Is there a reason you need to have the attribute load the timeout interval externally rather then to have the transaction derive it's timeout value from the attribute? The `Timeout`...

Allow specifying max test duration as a string-formatted TimeSpan

To expand a bit more: I'm hesitant about your proposed change. Dynamically loading the timeout here, especially from a non-static method, adds considerable complexity. For example, instance methods for "Source"...