Steven Weerdenburg

Results 453 comments of Steven Weerdenburg

Agreed, any fix here should be back ported if present on v3. I think it's worth considering that these attributes may be used for more than out-of-proc work. A use...

@OsirisTerje I admit, it's good to hear it was introduced more recently that 3.7.0. I'm not disputing the bug nature either, just surprised by the recency. So, is the change...

Ok, I'm fine with removing all the threading code if that's what we prefer. Perhaps my notion of "fallback code" is getting muddied somewhere. I think it's still important to...

Oh that's a neat idea @manfred-brands ! EDIT: I think I like that more than my notion of bringing MaxTime into Timeout as it allows earlier feedback

@manfred-brands I just realized that a suite relying heavily on a third-party assertion library (FluentAssertions, etc) may not call `Assert.That` directly so perhaps `IncrementAssertionCount` could be more broadly compatible

Thanks for catching that @manfred-brands ! They must be doing that to avoid a hard dependency. I'm also realizing now that it's plausible that tests could exist with no asserts...

@renemadsen Are you on .NET6+ by chance? The link shared by @manfred-brands also includes a suggestion for something like this from CLI (though I have not tried it myself) EDIT:...

This is a neat idea, so I'm going to label it `idea` for the team to consider. One thought about option 2 here is that if the `expected` is the...

@StarWars999123 Can you share a minimal repro? It should be as small as possible while still able to run "as-is" to make it easier for the team to investigate. One...

Thanks @StarWars999123 Sorry, a bit of a poor link there in my previous message. The option I meant to suggest for a PR is to our "issues" repo: https://github.com/nunit/nunit.issues A...