Steven Weerdenburg

Results 453 comments of Steven Weerdenburg

I don't have access to a rider install myself, but it looks like they should also support `.runsettings`. One option available to you with this approach could be to have...

Glad to hear it worked for you! :) My suggestion to inherit from `PropertyAttribute` was a minimal-code solution specific to your use case, but there is also some general documentation...

Oops, thanks for catching that! I've updated the description

NOTE to self or other reviewers. This may also fix: - #2610 - #3426

@lahma are you able to share any of the numbers you saw in #4035 ?

Thanks very much for the numbers @lahma ! I think there's still some discussion to be had about if we go ahead with optimizing the release build, but I at...

It sounds like there could be a general consensus that this is a good idea. @nunit/framework-team @nunit/core-team is anyone opposed to us moving forward with this?

Thanks for suggesting this @juwens There may have been a similar suggestion in the recent past here: https://github.com/nunit/nunit/issues/4020 Would you consider this a duplicate of that or is this something...

I second the notion of keeping it simple. FWIW I like the idea of using strings over enums when it comes to OS names. I suspect it will be easier...

Oh, actually, if we go with separate attributes, as @rprouse suggested, perhaps the "IsOSAttribute" could define 2 constructors (one for string representation and one for enum). If the internal representation...