Steven Weerdenburg
Steven Weerdenburg
@OsirisTerje I had a few concerns about the argument conversion aspect. Historically we have avoided that in TestCaseSource and instead encouraged users to simply pass their intended types rather than...
@OsirisTerje > Does this comment also apply to #3125 and the PR #5079 ? At a glance, yes. If single is not implicitly convertible to int then that example working...
> I'd hoped a quick discussion might be possible here to get clarity for this PR, but perhaps a dedicated discussion is better for visibility. I could spin one up...
Sorry for the delays here @manfred-brands Given past discussions seemed hesitant to add the parameter conversion and that my own PR accidentally introduced it, I thought it would be good...
@manfred-brands I see now that the parameter discussion has been open for about two weeks. It doesn't seem like there's been any objections raised which I am inclined to also...
@OsirisTerje I agree about implicit conversions. If it "just works" for regular method invocations in C# to pass arguments of one type into a method expecting another without explicit conversion...
Agreed with @OsirisTerje I like how we've separated that conversion split in this PR. I ran out of time tonight to do this review but I should be able to...
Thanks for your suggestions @manfred-brands I think all have been implemented now
Thanks @manfred-brands I like your simplifications, thanks for making them. I'm happy to merge this if you are. Each of the commits seem fairly self-contained and descriptive so I may...
This information should be accessible as of NUnit 4.2 by calling `TestContext.Current.AllPropertyValues()` which will walk up the test hierarchy and fetch and return all property values for a given key....