Shane F. Carr
Shane F. Carr
New WG discussion: Options: - Single format function: `format(impl IsInCalendar + AllInputMarkers)` - Concrete format functions: `format_date()`, `format_date_time()`, `format_date_time_zone()` Discussion: - @manishearth Would like generic to be exposed, if deprioritized...
I split the stretch goal to https://github.com/unicode-org/icu4x/issues/5861. The rest of this issue is done.
Based on [the ballot](https://docs.google.com/document/d/1Ol0aKsT252WKRavjb38iYZoh8rrFTw6mvKgf-5HB-Gs/edit#heading=h.w938ggnv6268), the winning crate name is: `icu_units_core`
I'm fine gating this based on the MultiFieldsVarULE const size improvement (#5240). However, as noted multiple times before (#5230), I am gravely concerned with what's happening with all our finely...
> > So, my position is that we should block currency/units/compact graduation on fixing this issue. > > Do we have other timeline pressure on these things? I'm happy to...
- @sffc I'd like to add this issue to the milestone. - @Manishearth I do not agree with the solution proposed in the OP. - @sffc I want the problem...
This works locally; why doesn't it work on CI? ``` error: environment variable `ICU4X_DIPLOMAT_COVERAGE_NIGHTLY` not defined at compile time --> tools/make/diplomat-coverage/src/main.rs:102:35 | 102 | .args(["install", std::env!("ICU4X_DIPLOMAT_COVERAGE_NIGHTLY")]) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | =...
The CI failure is before it gets around to `rustdoc-types`. Should we leave this one alone and close the PR?
Discussed this briefly with @robertbastian. Some points: - Basically the proposal is to store data as immutable slices instead of references to mutable structs - ZeroFrom is costly for nested...
You're right about `&[u8]` and `&VarZeroSlice` being the same. I'll switch to using `&VarZeroSlice`. Maybe 1, 2, 3 are better illustrated with examples: ```rust // Option 0, Current (not exactly,...