Shane F. Carr

Results 1773 comments of Shane F. Carr

In tabular form (each row builds on the one above it): | Scenario | File Size | User Time | Clock Time | Maximum Resident Set Size | |---|---|---|---|---| |...

Revisiting this since we're getting 143 errors again in CI. Here's where we're currently at on main: ``` $ cargo clean; /usr/bin/time -v cargo +nightly build -p icu_experimental --all-features ......

I made a reproducible, standalone case here: https://github.com/sffc/icu4x_compile_sample/tree/standalone You can also see some of my previous work on making changes in the July 30 commits on the main branch: https://github.com/sffc/icu4x_compile_sample/commits/main/

I added const constructors where they were most impactful in #5541. I don't consider this a long-term solution because: 1. Custom bake impls are unsafe and should generally be avoided...

I still think options 1 and 2 are on the table, at least for keys that would benefit from it. `ZeroFrom` has a runtime cost, but I don't anticipate it...

Thought: if we want to avoid the yoke, we could add a third DataPayload variant with a `'static` bound. The variants would be something like: ```rust enum DataPayloadInner { Yoke(Yoke),...

Related: https://github.com/unicode-org/icu4x/issues/2452

I realize I made a big typo in the title of this issue: we also need to fix LocaleCanonicalizer.

I want to save this discussion until after neo datetime is fully landed so that we can see exactly which error enums we're having to name in FFI.