Shane F. Carr

Results 1750 comments of Shane F. Carr
trafficstars

@robertbastian says he's fine with names so long as they are targeted/descriptive as opposed to reliant on the crate name.

Here's what we're looking at: ```rust #[derive(Debug, PartialEq, Eq)] #[repr(C)] #[diplomat::rust_link(icu::calendar::RangeError, Struct, compact)] #[diplomat::rust_link(icu::calendar::DateError, Enum, compact)] #[cfg(any(feature = "datetime", feature = "timezone", feature = "calendar"))] pub enum CalendarError { Unknown...

`DateTimeFormatterLoadError` probably has more variants than are reachable. Do we care? I don't really like the name of `CalendarParseError`. It applies to the parsing in both the icu_calendar and icu_time...

Brief discussion with @robertbastian: - Debug-assert the errors that we think are not reachable - Rename `CalendarParseError` to `Rfc9557ParseError`

Axioms I hold, part 1: - ICU4X architecture can be difficult to understand, even for core team members. - CODEOWNERS reflect, or _should reflect_, the team member with the strongest...

> So there's some nuance here. Sure, and I didn't mean to say that there must only be 1 codeowner. I agree that not all codeowners have the same expectations...

We should make sure that all of our tutorial md files are being tested.

Given that we currently have experimental code for this, and it ties in a lot with Temporal and the calendar work we've been doing, I think it should be a...

https://tc39.es/proposal-temporal/#sec-temporal-calendardateadd

Also see https://github.com/tc39/proposal-intl-era-monthcode/issues/32