Shane F. Carr

Results 1766 comments of Shane F. Carr
trafficstars

> I don't like `zeropattern`. When we've had `zeroX` utilities, it's usually because there is an existing `X`, and what `zeroX` brings to the table is zero allocation deserialization. When...

Based on [the ballot](https://docs.google.com/document/d/1Ol0aKsT252WKRavjb38iYZoh8rrFTw6mvKgf-5HB-Gs/edit#heading=h.kd16v8j77g0i), the winners are: - `icu_pattern` re-exported as `icu::pattern` - `icu_locale_core::preferences` re-exported as `icu::locale::preferences`

I had a mistake in my vote counting code, and for the question of icu_preferences, there is currently a tie between these two options: - `icu_locale_core::preferences` re-exported as `icu::locale::preferences` -...

https://github.com/unicode-org/icu4x/issues/5179#issuecomment-2289977370 - @robertbastian The preferences are small enough that they shouldn't impact compile time. New crates ar somewhat expensive. - @sffc We historically fragmented our code into large number of...

I just realized a fatal flaw with re-exporting `icu_pattern` as `icu::pattern`, at least in the short term. If it gets re-exported, then it means `icu_pattern` needs to be graduated, but...

I have definitely been thinking of `icu_pattern` more along with the timeframe of utilities 1.0, but perhaps we should upgrade it to be more along the timeframe of `icu_collections` or...

The second choice from the ballot was `icu_pattern` not re-exported, which is the status quo. `zeropattern` was polarizing, getting 3 top votes and 2 bottom votes.

- @sffc - `icu_pattern` is not stable yet so we can't re-export it as `icu::pattern`. It should eventually become stable, but maybe more on the timeline of other util crates....

@robertbastian can you do the crate renaming and reexporting agreed in this issue? I think what needs to be done is: - Move `utils/preferences` to be a sub-module of `icu_locale_core`...

@zbraniecki posted the following in chat: > Younis - can you locate the correct group in https://github.com/unicode-org/cldr-json/blob/main/cldr-json/cldr-units-modern/main/en/units.json ? > I'm comparing it to sd locale data > is it this...