icu4x icon indicating copy to clipboard operation
icu4x copied to clipboard

Use makefile nightly in diplomat-coverage

Open sffc opened this issue 1 year ago • 4 comments
trafficstars

Follow-up to #5283

sffc avatar Jul 23 '24 23:07 sffc

This works locally; why doesn't it work on CI?

error: environment variable `ICU4X_DIPLOMAT_COVERAGE_NIGHTLY` not defined at compile time
   --> tools/make/diplomat-coverage/src/main.rs:102:35
    |
102 |                 .args(["install", std::env!("ICU4X_DIPLOMAT_COVERAGE_NIGHTLY")])
    |                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: use `std::env::var("ICU4X_DIPLOMAT_COVERAGE_NIGHTLY")` to read the variable at run time
    = note: this error originates in the macro `std::env` (in Nightly builds, run with -Z macro-backtrace for more info)

error: environment variable `ICU4X_DIPLOMAT_COVERAGE_NIGHTLY` not defined at compile time
   --> tools/make/diplomat-coverage/src/main.rs:108:21
    |
108 |                     std::env!("ICU4X_DIPLOMAT_COVERAGE_NIGHTLY"),
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: use `std::env::var("ICU4X_DIPLOMAT_COVERAGE_NIGHTLY")` to read the variable at run time
    = note: this error originates in the macro `std::env` (in Nightly builds, run with -Z macro-backtrace for more info)

sffc avatar Jul 23 '24 23:07 sffc

I don't know why it doesn't work in CI, but even locally this shouldn't work, because the rustdoc-types dependency is tightly coupled to nightly ranges.

robertbastian avatar Jul 24 '24 08:07 robertbastian

The CI failure is before it gets around to rustdoc-types.

Should we leave this one alone and close the PR?

sffc avatar Jul 25 '24 03:07 sffc

We should try to update to a newer (but pinned) nightly here if possible but I don't think it's super important

Manishearth avatar Jul 25 '24 05:07 Manishearth