Shane F. Carr

Results 1750 comments of Shane F. Carr
trafficstars

~Actually, in most constructors we are _already_ using ZeroFrom, so I'm not convinced that option 1 is actually a regression from the status quo. I think it's basically equivalent, we...

Yes, I briefly forgot about `DataPayloadInner::StaticRef`. So options 0 and 1 are different, as claimed in the OP. Option 3 is equivalent to the current solution, option 0 (not option...

A more radical solution (bigger change but maybe better outcome) would be to add it to DynamicDataMarker ```rust pub trait DynamicDataMarker { type Borrowed Yokeable>; } ```

The other way to implement option 1 would be to have a databake derive attribute that defines how to get from the static representation to the struct, which we could...

This is not 2.0 blocking unless we implement a breaking solution for #5187

- @sffc - Broke in Rust nightly - @robertbastian - Not convinced current suggestions will improve compile times - @sffc - # 2 (build `PackedSkeletonDataV1` at runtime) would produce the...

To add some urgency to this issue, @kartva says: > Compiling `icu_experimental` on main causes rustc to reliably crash on my laptop due to out-of-memory errors. Are there servers or...

Building the latest icu_experimental data: ``` Command being timed: "cargo build" User time (seconds): 30.57 System time (seconds): 8.20 Percent of CPU this job got: 100% Elapsed (wall clock) time...

Here are the figures for `impl_units_display_name_v1_marker!(Baked);` by itself: ``` Command being timed: "cargo build" User time (seconds): 18.72 System time (seconds): 5.43 Percent of CPU this job got: 100% Elapsed...

Here's with changing the paths to be imported instead of absolute: ``` Command being timed: "cargo build" User time (seconds): 17.70 System time (seconds): 5.07 Percent of CPU this job...