Scott Schurr
Scott Schurr
There are a lot of changes here, clearly more than I could realistically review to any depth. Do you have some guidance for where I should spend my review time?...
For the most part, this is a well done pull request. The tests seem to have good coverage of the new code. I have one serious concern with the implementation....
@shawnxie999, the most recent commit introduced significant changes. It would be good if you could re-review this pull request. Thanks.
I think this pull request looks good, but my view is colored by my own changes to the pull request. So I'm removing myself as a reviewer. @HowardHinnant has agreed...
I've looked into this briefly, and I can't guarantee that I understand all the details. But here's my understanding at the moment. Peer messages are one of several kinds of...
@sophiax851, unfortunately it's non-trivial to test the performance gain in a lab. The paths for the different key types need to be identified and fixed before the performance test can...
I took a quick glance at a few of these. A number are in areas I'm not comfortable talking about without a lot of study. But I'll hazard a thought...
## TL;DR Summary In my opinion we have a choice between three options: 1. We decide that this problem has not bitten us yet and choose to live with the...
No, you don't need to do anything special about running out of memory. If rippled runs out of memory it bursts into flame. There's no special handling for low memory...
This pull request had become particularly stale. Since there have been no active reviews yet, I rebased the pull request to the latest develop.