Scott Schurr

Results 107 comments of Scott Schurr

@WietseWind, thanks for your comment. I'm not really a load balancer kind of guy. I mostly keep my nose in the C++. So I'm happy to use your suggestions for...

@WietseWind, I'm hoping you'll have time to indicate where you'd like additional HTTP status codes added. Is there anything you need from me to push that forward? Thanks.

Hey @WietseWind, on April 11th you noted: > If you agree I'll go through the list and add some more 4xx/5xx status codes. That's great and would be appreciated. But...

Thanks for the help @WietseWind. I've added a commit with the extra status codes and a bit more code that was required to make the new status codes work. I...

Ping @cjcobb23 and @mDuo13. How do you folks feel about this pull request in its current state? Do you want any changes? Thanks.

I've pushed a commit that adds the HTTP status codes suggested by @mDuo13. It also gates returning this status codes based on the `"ripplerpc"` field of the original request being...

Rebased to 1.9.2. @mDuo13 and @WietseWind, are you good with this version of the code? Thanks.

Thanks @mDuo13. If you think these changes are ready to be committed, could you please mark the pull request as approved? But, since you want more time to research the...

@Mwni, thanks for the effort you put into this pull request. Also sorry that this amendment has been sitting so long. Your pull request prompted me to do some research...

Hi @Mwni, thanks for your patience. I have an alternative proposal to this pull request here: https://github.com/XRPLF/rippled/pull/4264 Personally, I'm more comfortable with the approach taken by https://github.com/XRPLF/rippled/pull/4264 because the ledger...