Scott Schurr

The most recent version of this pull request fails the clang-format check. The top-most commit on this brand will fix that: https://github.com/scottschurr/rippled/commits/nik-jqt-clang-format Other than the clang-format problems, is this branch...

Thanks @mDuo13! @cjcobb23, it's now your call.

@mDuo13, or whoever addresses this, please think about how the XRP Ledger could be changed so removing a trust line is not so painful. For example, is there something we...

Thanks for the review @seelabs! I've addressed your comment. I also rebased to 1.10.0-b2 so I could test syncing without being amendment blocked.

@intelliot, this is absolutely worth doing. However after rebasing a number of the tests are failing. I suspect there's fallout from the `Number` class merge and unification, but I haven't...

Closing until newly introduced test failures are resolved.

@HowardHinnant, I had the same problem. I was able to compile (pre-conan-style) If I cherry-picked the following two commits on top of this pull request: - 5d38e4cfbfe457999f942ba09bff789e06bb81f9 - f5af42a64089ab0563c343a9eba234627d8afe5e

@thejohnfreeman, unfortunately the "See #4217 (comment)" links are not leading me to a reliable place. So I can't figure out what it is you're trying to say with those links....

@thejohnfreeman, thanks for the explanation of how the links are intended to work. I was not paying enough attention to which comments were marked as resolved. I now understand the...

@intelliot, I'm not ignoring you, but I have another higher priority code review I'm working on. I can't predict whether or not I'll get to this one in the coming...