Scott Schurr

Worked for me on macOS Catalina 10.15.7, Apple clang version 12.0.0 (clang-1200.0.32.21).

Is `tecKILLED` really the right `tec` code to use if the `tfImmediateOrCancel` flag is set? The descriptive text that goes with `tecKILLED` is "FillOrKill offer killed". Seems like that might...

Hmmmm. I'm digging into the details of this a little harder. If I'm understanding correctly, a `tfImmediateOrCancel` offer _never_, under any circumstances, creates an on-ledger offer. Instead it crosses as...

Okay, I can work with that. So we change the descriptive text associated with `tecKilled` to read `"No funds transferred and no offer created"`? I believe that applies in both...

Yes, @Aena11, it doesn't look like anybody else is making forward progress on this at the moment. Your contribution would be welcome. The links provided by @nbougalis are a little...

@brianfranco141, this work has not been done and I've seen no evidence of pull requests aimed at addressing it. There's been no news on this from @Aena11 for 6 months...

I'm assuming that the caching is purely to reduce execution time. To that end, I timed execution of `std::string toBase58(AccountID const& v)` in the application with an optimized build. I...

Gah. There is, of course, a bug in my timing code. The good news is that it does not obviate the results. All of the results above are in units...

Having thought about this for a little while, I'm inclined toward adopting @seelabs' change rather than this one. @seelabs' change will improve both encoding and decoding of all base58 values,...

I really like the changes that were made to this pull request. I especially like replacing the hash table with an array. Very clever. Given the changes I decided that...