rippled
rippled copied to clipboard
[Trivial] Remove unused constants from resource/Fees.h
High Level Overview of Change
While reviewing other code I stumbled across a number of constants defined in resource/Fees.h that are unused anywhere in the code base. They did no harm, but it seems untidy to leave them lying around. This commit removes the unused constants.
I also tidied up some messiness left by clang-format.
Type of Change
- [x] Refactor (non-breaking change that only restructures code)
This pull request had become particularly stale. Since there have been no active reviews yet, I rebased the pull request to the latest develop.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 71.4%. Comparing base (
a39720e) to head (47cef90).
Additional details and impacted files
@@ Coverage Diff @@
## develop #4856 +/- ##
=========================================
- Coverage 71.4% 71.4% -0.0%
=========================================
Files 796 796
Lines 67042 67042
Branches 10863 10866 +3
=========================================
- Hits 47844 47843 -1
- Misses 19198 19199 +1
I'll do the rebase. I should be able to get it done today.
Per offline discussion, the merge was actually easy, so I pushed it.
Presumably, this will be ready for merge once CI passes (unless it needs to be caught up to develop again).