Scott Schurr

As far as I can tell there are no active code reviews running. So I've rebased this pull request in order to allow it to be built by conan.

@ckeshava identified some places that the `AcctRoot` was not being used but could be. The most recent commit incorporates @ckeshava's suggested changes.

The most recent commit is a change suggested by @ckeshava.

I looked over @TheJohnFreeman's alternative design. I spotted what I consider to be a big flaw and a smaller issue. 1. Each wrapper _is_ an `STLedgerEntry`. So the wrapper no...

> Objection 1 does not require private inheritance. It can be addressed by making specific methods private in the derived classes with using-declarations. Or you can have an intermediate base...

At this point I think it's appropriate to back up and reflect on where this pull request came from. At the time this code was initially developed, about June of...

Closing due to a mismatch between the apparent value of the change and the cost of resolving design disagreements.

Judging by some of the added commits I thought that maybe the problem with in-ledger attestors with disabled master keys had been addressed. But it looks like I was wrong...

Since attestations are no longer batched I think it would be worthwhile to audit XChain related names that include "batch". Maybe you want to save some of these names intentionally,...

Travis build failed. Expected?