Sam Clegg

Results 1093 comments of Sam Clegg
trafficstars

I believe this was fixed in #22946

This seems like maybe an issue for the WASI repository?

I don't have permission to do that. Perhaps @dschuff can do it?

The core spec doesn't specify anything to do with filesystems. Any discussion of filesystem APIs likely belongs in the WASI repo. I suggest we move this issue there.

Can you build with `-g` or `--profiling-funcs` so we can see a more useful backtrace?

Oh, I see what is happening. The default in `__temp_directory_path` is `/tmp` and I guess that path does not exist on windows. `__temp_directory_path` will also check for `"TMPDIR", "TMP", "TEMP",...

I believe `ht` refers to Heap Type which would not be needed for function references. I believe heap types refer to things like structs and arrays in the GC proposal.

> I have found a bug in RecursiveMatch and fixed it. It seems there will be no other comments to this patch, @sbc100 you are my only hope. I think...

I'm on vacation for the next couple of week, but I will make a concerted effort to review this change when I get back in July.

lgtm! (What about update-spec-tests.py?)