Sam Clegg

Results 1136 comments of Sam Clegg

Thank you Zoltan, and again sorry for the absurd review time.

Maybe open a bug in https://github.com/cloudflare/doom-wasm? It looks like a crash in `P_PlayerThink`? You would build with `-g` and then debug in devtools, or add some tracing/logging do see how/why...

Can you try building with `-sEXIT_RUNTIME=1` and then calling `exit()`? The runtime shutdown process should terminate all the workers.

> There was quite a bit of discussion on this, but I can't find it because the memory64 repo was archived. I would hope that archiving the repo didn't destroy...

How about using `-P` flag when starting the python interpreter instead of `PYTHONSAFEPATH`? That way only the py_binary itself would be effected and not all of its transitive sub-processes?

Can you attach the offending wasm file? Also, using wasm-dis to disassembly it might give you a clue as to how references crept in. I don't think emscripten itself generates...

I imagine that `references are not enabled` is safari's way of saying that you have a reference type in your code. What version of safari is running the device? The...

No, it has nothing to do with C++ or `&` in your code. What version of safari is running on the device that rejects the binary?

Interesting, so 3.1.25 itself is more than 2 years old, so I'm somewhat supprised that it wouldn't work with Safari 14. Can you try building with the very latest version...

The compilation failure looks related to recent changes to libc++ regarding std::string. See #23070. Regarding the error you are seeing on the phone, can you find out what is at...