Oli Scherer

Results 712 comments of Oli Scherer

> As I understand "maintenance mode", the authors does not write any code, except "critical bugs and security vulnerabilities", but review incoming PRs and releases new version with fixes, made...

> Are you worried about those who have errors in serde break their erroneous code, but not those who have these errors that prevent them from writing correct code? It's...

> is the set of impls chosen to be suggested by rustc. Is there something we can do with `doc(hidden)` to exclude nonpublic APIs from this error message? If not,...

The idea is to not re-generate the files in every build, but generate them once and put them onto crates.io. This way crates using syntex won't even have to depend...

Maybe these implementations https://github.com/erickt/rust-quasi/blob/master/src/lib.rs#L37-49 could be changed to an impl for `Iterator`

These constants (almost?) always have a corresponding ErrKind, so I think we can transform them to `io::Result` usage. I mean, that is how we convert `io::Error` to an error value...

Separate idea: instead of hardcoding the io::Result to integer conversion logic, we add a new enum around `io::Error` that has variants for the extra cases we need. Then we use...

I have figured out what the `.fixed` issue is and am currently refactoring to fix it. Not sure yet what the issue is with the missing final report

Please squash the commits, then r=me @bors delegate+