rust-clippy
rust-clippy copied to clipboard
rust-lang
Revert "Bump ui_test to 0.23"
#12746 introduced very buggy behaviour (.fixed tests not being checked, not showing what went wrong... etc.), this commit reverts that and it should fix all those issues. We'll check again once ui_test 0.24.0 is available.
r? @y21
rustbot has assigned @y21. They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Did you already report this issue to ui_test and will it be fixed with 0.24?
Is the issue just that no summary is printed or that the files don't actually get checked, resulting in broken tests?
Maybe https://github.com/oli-obk/ui_test/issues/176 could also be related? There was a time, where ui_test blessed files automatically, which would prevent any errors
Just tested this, seems that while the testing is not shown on screen, if the .fixed file was different it would output an error.
It's still quite annoying that the screen doesn't refresh to show this, and that it isn't uncommon to not show output. After commenting it to Timo on #12830, he sent this screenshot about how it looks.
EDIT: On CI it seems like there aren't any issues, could you test the patch on your PC to check? Maybe it's just my workflow
Oh sorry, didn't see this edit. Huh... yeah, I'm seeing something similar.
I don't think this is something caused by this PR though. It also seems to happen on master for me.
Anyway, I'll try taking a closer look at the changes in a bit
Running UI tests a few times the last few days, I also noticed this bug. It goes away when running with blessing, I think. But since it is just a visual bug, I would rather not downgrade ui_test again. This would introduce multiple ui_test versions in rustc and it might make it harder to upgrade once 0.24 is released (with this potentially fixed).
I have figured out what the .fixed issue is and am currently refactoring to fix it. Not sure yet what the issue is with the missing final report
There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.
You can start a rebase with the following commands:
$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust-clippy.git master
$ git push --force-with-lease
The following commits are merge commits:
- e54627988d7ed643587cfd18e9acf005a2938f95
?? This shouldn't have propagated here? I was just testing a test bot and using this branch as a test for a PR (in my Clippy fork.) I'll close the PR, and let's see if the issue gets fixed on future versions.