Oli Scherer comments

Results 704 comments of


                                            Oli Scherer

Fix accidental type inference in array coercion

@rustbot author

use cargo_util_schemas::{PackageName, FeatureName}

I don't care about the validation, but sharing data types with cargo may be a useful way forward to slowly making cargo_metadata mostly a set of convenience functionality

use cargo_util_schemas::{PackageName, FeatureName}

That's quite an MSRV bump. What's the earliest rustc version that supports `rust-version` in `Cargo.toml`? Maybe we can first bump to that and add an MSRV to cargo_metadata. Then when...

use cargo_util_schemas::{PackageName, FeatureName}

Oh neat, thanks! edit: lol we already use `rust-version` here.

use cargo_util_schemas::{PackageName, FeatureName}

Oh well, let's bump the rust-version. It's a major version bump, and anyone using an old cargo to compile cargo_metadata to use it on a newer crate is already asking...

use cargo_util_schemas::{PackageName, FeatureName}

I manually merged this into master after resolving the merge conflicts Thanks for providing the PR!

fix unused_async with macros and sub async block

Weird that it's only happening in CI... the full stderr doesn't really fit the diff you posted either. If it's a recurring thing, open an issue

gpu offload host code generation

> I don't want to add any actual run tests, as these would require a working clang based on the same commit. why is clang necessary for this?

gpu offload host code generation

Yea, without real deduplication they don't help too much. Sad. Maybe a closure would've worked. r=me with a rebase and squash. Feel free to remove the latest helpers if you...

Switch to GH merge queue?

Can we set PR CI to make all CI runs "optional", so their failure is irrelevant. That may allow the merge queue addition, we just need to ensure that the...