Oli Scherer comments

Results 699 comments of


                                            Oli Scherer

Allow passing a function name to rename_all and rename_all_fields

I don't think this is doable. These functions would need to be run at derive time, which is a concept rustc does not support yet (unclear if ever).

Discussion: Updating and Formalizing Council Expections for Project Director Communication

I don't think we should be doing that for every board meeting. I think having the board meeting doc ahead of time for the LC to have a look and...

Serializing fields from a getter method.

I agree, and our docs already suggest writing a custom impl if the existing attributes do not serve your purpose

Emit an error if a variant of an untagged enum is annoted with `#[serde(rename)]` or `#[serde(alias)]`

Can someone run crater-at-home on this to gauge the impact? I worry someone accidentally is using it in a crate that will impact many other crates. Or switch it to...

Always delegate returning errors to the Visitor from Content[Ref]Deserializer

Pinging is not changing our priorities in any useful way We know which PRs are open and if our free time allows we make some progress on it.

Always delegate returning errors to the Visitor from Content[Ref]Deserializer

Please fork it instead. That is much more sustainable in the long run

Always delegate returning errors to the Visitor from Content[Ref]Deserializer

Why do you need to replace the derives of your deps? Are the issues you have not contained to a single derive expansion but affected by the way fields' types...

Always delegate returning errors to the Visitor from Content[Ref]Deserializer

`serde` changes should be rare and well thought through. They are effectively on the level of getting a change into libstd at this point. I have several times brought up...

Always delegate returning errors to the Visitor from Content[Ref]Deserializer

Releasing a new version is just as easy as forking under a different name. If you believe that to be the way forward, there is nothing stopping you. There is...

Maintenance status of serde

I think the right approach is to finish the `serde_core` work and let the community handle forking and modularizing `serde_derive`. No one is actually blocked on that tho, as you...