Oli Scherer

Results 704 comments of Oli Scherer

> tests for this will be hard because the default behavior doesnt change. if you change the deserializers in https://github.com/serde-rs/serde/blob/master/serde/src/de/value.rs#L264 to support this, is there anything else missing from https://github.com/serde-rs/serde/blob/master/test_suite/tests/test_de.rs...

> (For some justification of this, [in rust itself they hide deprecation messages in derives](https://github.com/rust-lang/rust/pull/58994), so in my opinion this would put serde more inline with expected behavior.) in theory...

No... this is mostly me not wanting to add workarounds that are necessary because of other workarounds. w

Considering the low cost to maintenance this PR adds, gonna merge it as is

I think it's ok for `Validate` to be required in the list of derives, but I do like the idea of an emtpy `serde(validator)` to just expand to `validator::Validate::validate` and...

Removing T-lang as this is not implementable, so it seems like it's just T-types territory. I agree that the motivation to catch issues exists, but I don't think it's an...

@rfcbot fcp cancel I've been told more discussion is warranted

so... there are multiple moderately related issues at hand (mostly repeating what lcnr said in a different order): 1. You can't implement traits for unsized types at all if they...

> My conclusion thus is still to close the RFC, and just implement allowing > > ```rust > trait Foo { > fn foo(self) where Self: Sized; > } >...