Oli Scherer

Results 712 comments of Oli Scherer

No, you can set CI runs as not blocking the merge button from becoming green. Even if the CI run shows up red. The only question is if we can...

yea I've wanted this as a general rustc feature before, but it can't really work because some flags are processed before the source file is even opened. I think I...

Jup, tho with recent feedback we may just switch to using newtype wrappers defined in cargo_metadata itself

> Sorry, what are you referring to? https://github.com/oli-obk/cargo_metadata/issues/63#issuecomment-2911517148

Well if we are making a breaking change anyway, we could just move to our own newtype wrappers

Verification is not necessary and not too useful as cargo is who provides the json to us

> Applying the below patch in that function seems to resolve the issue, but I'm not too familiar with the `serde` code so please let me know if you think...

Oh fun, there's a bug somewhere. Either in miri or in this crate. I'll need to minimize the test before it's clear what's up.