Lorenz Walthert

Results 536 comments of Lorenz Walthert
trafficstars

We are not bound by CRAN version of {styler} (because we user env to manage versions and styler is already pinned to a GitHub version), so we could already implement...

Yes, that should work. If the hook release `v0.3.2` already includes a styler version that's large enough, you don't need the `additional_dependencies`.

Maybe, if they are parsable R code we could do that. Note that people can have unparsable headings, such as ```{r, if=b, c=d} message("Hi!") ``` And therefore, we had #832.

Well it’s not parsable, I added `c(` and `)` to it to make it parsable. That way, it was easier to find the keys. Now, I’d tue argument has key=value,...

Approach would be to parse if possible, then style that character vector with styler and return it. I’d not parsable, use the workaround in #832.

The reason why we understood them as parsable R code first (wrapped between `c(` and `)`) is because then, we don't have to deal with quoting, which can occur in...

Great start @IndrajeetPatil always good to start with a skeleton and a test. I’d just put `browser()` in your skeleton and run the test. Then, `token`, `token_before` and `token_after` might...

Ah and before we forget: at the end, we should also add a transformer drop rule.

This would be very much appreciated @allisonhorst.

@allisonhorst are you still interested in designing a sticker for {styler}?