Lorenz Walthert

Results 536 comments of Lorenz Walthert
trafficstars

pre-commit may ultimately support running on diff only: https://github.com/pre-commit-ci/issues/issues/90

Yes. System libraries are not supported with pre-commit.ci as explained in the vignette: https://lorenzwalthert.github.io/precommit/articles/ci.html This is all because roxygen requires pkgload requires system dependency. 😩 that’s maybe why we should...

Thanks @russHyde. What about the option to lint the whole package instead of the staged files? Is that also an option? I prefer to not use `pkgload::load_all()` because that requires...

Is there smart caching built in in {lintr}, or is running it on all files significantly slower?

ok @TNonet I think I found the problem. Quite annoying combination of `here::here()` as the default value for `root` (after setwd()`, it's not updated) and some weird {git2r} behaviour. Anyways,...

Which hook version are you running? Iirc this was fixed in a recent hook patch update. Try `pre-commit autoupdate` on the command line or `precommit::autoupdate()` in R. The warning on...

Maybe we also need to catch these types of errors in all hooks and suggest updating the various components.

The install process is implemented in the upstream framework https://pre-commit.com, as part of the `language: r` functionality (I contributed it). The source code is [here](https://github.com/pre-commit/pre-commit/blob/main/pre_commit/languages/r.py#L145). Did you figure out how...

Well not exactly. Clarification: your repo does not have to use renv. pre-commit has its own install mechanisms based on renv. So all I need you to do is to...